Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase the search XMLRPC disable error #12173

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Conversation

pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Sep 2, 2022

Based on the idea from pypa/pip#5216 (comment).

This reflects the current state of the service more accurately and also
serves as a friendlier error message for "pip search" runs.
@pradyunsg pradyunsg requested a review from a team as a code owner September 2, 2022 17:42
@pradyunsg
Copy link
Contributor Author

I coded this on github.dev, so... lemme know if something is horribly borked. 😅

@pradyunsg
Copy link
Contributor Author

Anything I can do to help this move forward?

@ewdurbin ewdurbin requested review from di and brainwane November 15, 2022 18:45
@ewdurbin
Copy link
Member

Gutted implementation of search, overhauled XMLRPC doc, and added reference to it in deprecation messages.

@ewdurbin ewdurbin enabled auto-merge (squash) November 15, 2022 18:49
ewdurbin added a commit to pypi/infra that referenced this pull request Nov 15, 2022
@ewdurbin ewdurbin merged commit 05f38f9 into pypi:main Nov 15, 2022
ewdurbin added a commit to pypi/infra that referenced this pull request Nov 15, 2022
@pradyunsg pradyunsg deleted the rephrase-xmlrpc branch November 15, 2022 19:30
@pradyunsg
Copy link
Contributor Author

Thanks for taking this over the line @ewdurbin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants